Fix first-run setup timing out on the kernel download

On a Mac without the Linux kernel, setup ran `container system start
--enable-kernel-install` with a 120 s limit. That command downloads a
697 MB archive without printing anything, so most connections hit the
limit and the window showed `timedOut([...])`.

- Start the service with --disable-kernel-install (10 min: a first
  start still pulls the 69 MB base filesystem).
- Download the kernel in its own step with progress, then hand the file
  to `container system kernel set --tar ... --digest ...`, which checks
  it against the runtime's digest.
- Opening the setup window no longer starts the download; Set Up does.
- Timeouts and runner errors read as sentences.
- A rebuild deletes the image it replaced, which frees about 2 GB each
  time, and deletes or stops the builder VM unless it was already
  running (it kept about 2.8 GB of memory).
- Setup asks for 10 GB free, measured on a real setup.
This commit is contained in:
aculix committed 2026-09-29 16:25:50 +05:30
1 parent 4b67728cce
commit 9fd654298a
13 files changed
+559 -128

No files matched your search

+1
View File
@@ -158,6 +158,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
quitting = true
setupFlow.cancel()
if setupFlow.isDownloading { SystemRuntimeInstaller.removeLeftovers() }
if controller.state == .settingUp(.kernelMissing) { ContainerCLIBackend.removeKernelDownloads() }
// Not Now mid-build closes the window before the build ends.
if setupFlow.allRequiredDone { UserDefaults.standard.set(true, forKey: SetupLaunchRule.completedKey) }
// Synchronous on purpose: terminate: often runs inside a non-reentrant main-queue block; awaiting here deadlocked.
+2 -1
View File
@@ -205,7 +205,8 @@ struct SessionSummary {
switch issue {
case .cliMissing: "Installing the container runtime…"
case .cliOutdated: "Updating the container runtime…"
case .serviceStopped, .kernelMissing: "Starting the container runtime…"
case .serviceStopped: "Starting the container runtime…"
case .kernelMissing: "Downloading the Linux kernel…"
default: "Building the VM…"
}
}
+10 -5
View File
@@ -553,7 +553,8 @@ private enum Setup {
static func symbol(_ issue: SetupIssue) -> String {
switch issue {
case .cliMissing, .cliOutdated: "shippingbox"
case .serviceStopped, .kernelMissing: "power"
case .serviceStopped: "power"
case .kernelMissing: "arrow.down.circle"
case .imageMissing, .imageOutdated: "square.and.arrow.down"
case .imageStale: "arrow.triangle.2.circlepath"
case .lowDisk: "internaldrive"
@@ -564,7 +565,8 @@ private enum Setup {
switch issue {
case .cliMissing: "Knotchy needs Apple's container runtime"
case .cliOutdated: "Knotchy needs a newer container runtime"
case .serviceStopped, .kernelMissing: "The container service isn't running"
case .serviceStopped: "The container service isn't running"
case .kernelMissing: "The container runtime needs its Linux kernel"
case .imageMissing, .imageOutdated: "The browser VM image needs to be built"
case .imageStale: "Updating the browser VM"
case .lowDisk: "Not enough disk space"
@@ -575,7 +577,8 @@ private enum Setup {
switch issue {
case .cliMissing: "Installing the container runtime…"
case .cliOutdated: "Updating the container runtime…"
case .serviceStopped, .kernelMissing: "Starting the container runtime…"
case .serviceStopped: "Starting the container runtime…"
case .kernelMissing: "Setting up the container runtime…"
default: title(issue)
}
}
@@ -584,7 +587,8 @@ private enum Setup {
switch issue {
case .cliMissing: "Set it up in one step; the link opens when it's done."
case .cliOutdated: "Update it in one step; the link opens when it's done."
case .serviceStopped, .kernelMissing: "Start it to run the isolated browser."
case .serviceStopped: "Start it to run the isolated browser."
case .kernelMissing: "It's a 700 MB download. The link opens when it's done."
case .imageMissing, .imageOutdated: "This takes about 3 minutes and downloads about 225 MB."
case .imageStale: "Rebuilding gets the latest WebKit security fixes."
case .lowDisk(let free): "Only \(free / 1_000_000_000) GB free; a session needs about 2 GB."
@@ -594,7 +598,8 @@ private enum Setup {
static func action(_ issue: SetupIssue) -> String? {
switch issue {
case .cliMissing, .cliOutdated: "Set Up…"
case .serviceStopped, .kernelMissing: "Start Service"
case .serviceStopped: "Start Service"
case .kernelMissing: "Download"
case .imageMissing, .imageOutdated: "Build Image"
case .imageStale: "Update Now"
case .lowDisk: nil
@@ -3,6 +3,8 @@ import Synchronization
public final class ContainerCLIBackend: VMBackend {
public static let image = "local/knotchy-vm:latest"
/// The image a rebuild replaces, named so it can be deleted afterwards.
static let previousImage = "local/knotchy-vm:previous"
public static let staleAfterDays = 14
private let cli: CLIRunner
@@ -271,30 +273,164 @@ public final class ContainerCLIBackend: VMBackend {
// MARK: Setup actions
/// A first start also pulls the runtime's base filesystem, about 70 MB.
static let serviceTimeout: TimeInterval = 10 * 60
/// A first build downloads about 470 MB: the builder, the Debian base and its packages.
static let buildTimeout: TimeInterval = 60 * 60
static let kernelFolderPrefix = "knotchy-kernel-"
public func fix(_ issue: SetupIssue, output: @escaping @Sendable (String) -> Void) async throws {
switch issue {
case .serviceStopped, .kernelMissing:
let result = try await cli.run(["system", "start", "--enable-kernel-install"], timeout: 120, line: output)
case .serviceStopped:
// The kernel is its own step: `--enable-kernel-install` downloads 700 MB without showing progress.
let result = try await step(["system", "start", "--disable-kernel-install"], timeout: Self.serviceTimeout,
output: output, named: "Starting the container service")
guard result.status == 0 else { throw VMBackendError.failed("Couldn't start the service: \(result.lastLine)") }
case .kernelMissing:
try await installKernel(output: output)
case .imageMissing, .imageOutdated, .imageStale:
guard let vmSources else { throw VMBackendError.failed("The VM sources are missing from the app.") }
let now = Date()
let day = DateFormatter()
day.dateFormat = "yyyy-MM-dd"
let args = [
"build", "--cpus", "4", "--memory", "4g", "--dns", "1.1.1.1", "--pull",
"--build-arg", "APT_REFRESH=\(day.string(from: now))",
"--build-arg", "BUILD_DATE=\(ISO8601DateFormatter().string(from: now))",
"-f", vmSources.appendingPathComponent("Containerfile").path,
"-t", Self.image, vmSources.path,
]
let result = try await cli.run(args, timeout: 15 * 60, line: output)
guard result.status == 0 else { throw VMBackendError.failed("The image build failed: \(result.lastLine)") }
try await buildImage(output: output)
case .cliMissing, .cliOutdated, .lowDisk:
throw VMBackendError.failed("There's no automatic fix for this.")
}
}
/// Leaves nothing behind but the new image: not the one it replaced, and not a builder it started.
private func buildImage(output: @escaping @Sendable (String) -> Void) async throws {
guard let vmSources else { throw VMBackendError.failed("The VM sources are missing from the app.") }
let now = Date()
let day = DateFormatter()
day.dateFormat = "yyyy-MM-dd"
let args = [
"build", "--cpus", "4", "--memory", "4g", "--dns", "1.1.1.1", "--pull",
"--build-arg", "APT_REFRESH=\(day.string(from: now))",
"--build-arg", "BUILD_DATE=\(ISO8601DateFormatter().string(from: now))",
"-f", vmSources.appendingPathComponent("Containerfile").path,
"-t", Self.image, vmSources.path,
]
let builderBefore = (try? await cli.run(["builder", "status", "--format", "json"], timeout: 15))
.flatMap { Self.builderState(in: $0.text) }
// The runtime keeps a replaced image's files, about 2 GB, until an image is deleted. Deleting the
// old one by name frees them, along with anything earlier builds left.
let named = (try? await cli.run(["image", "tag", Self.image, Self.previousImage], timeout: 30))?.status == 0
let built: Result<CLIRunner.Output, any Error>
do {
built = .success(try await step(args, timeout: Self.buildTimeout, output: output, named: "Building the VM image"))
} catch {
built = .failure(error)
}
// After a failed build the old image keeps its usual name too, so this deletes nothing it needs.
if named { _ = try? await cli.run(["image", "delete", Self.previousImage], timeout: 5 * 60) }
// The builder VM keeps about 3 GB of memory and a 4 GB cache. One the user had running stays as it was.
switch builderBefore {
case .absent?: _ = try? await cli.run(["builder", "delete", "--force"], timeout: 60)
case .stopped?: _ = try? await cli.run(["builder", "stop"], timeout: 60)
case .running?, nil: break
}
let result = try built.get()
guard result.status == 0 else { throw VMBackendError.failed("The image build failed: \(result.lastLine)") }
}
enum BuilderState: Equatable {
case absent
case stopped
case running
}
/// From `builder status --format json`: `[]` when there's no builder.
static func builderState(in json: String) -> BuilderState? {
struct Entry: Decodable {
struct Status: Decodable {
let state: String?
}
let status: Status?
}
guard let entries = try? JSONDecoder().decode([Entry].self, from: Data(json.utf8)) else { return nil }
guard let first = entries.first else { return .absent }
return first.status?.state == "running" ? .running : .stopped
}
/// A timeout reads as a sentence, not as the command that ran.
private func step(_ args: [String], timeout: TimeInterval, output: @escaping @Sendable (String) -> Void,
named name: String) async throws -> CLIRunner.Output {
do {
return try await cli.run(args, timeout: timeout, line: output)
} catch CLIRunner.Failure.timedOut {
throw VMBackendError.failed("\(name) took over \(Int(timeout / 60)) minutes, so Knotchy stopped it. Check your connection and try again.")
}
}
public static func removeKernelDownloads() {
FileDownload.removeFolders(prefix: kernelFolderPrefix)
}
/// `kernel set --recommended` prints nothing while it downloads 700 MB, so Knotchy downloads the archive
/// itself, with progress, and hands it over. The runtime still checks it against the digest it publishes.
private func installKernel(output: @escaping @Sendable (String) -> Void) async throws {
let properties = try? await cli.run(["system", "property", "list", "--format", "json"], timeout: 15)
guard let kernel = properties.flatMap({ Self.recommendedKernel(in: $0.text) }) else {
let result = try await step(["system", "kernel", "set", "--recommended", "--force"], timeout: 60 * 60,
output: output, named: "Downloading the Linux kernel")
guard result.status == 0 else { throw VMBackendError.failed("Couldn't install the Linux kernel: \(result.lastLine)") }
return
}
Self.removeKernelDownloads()
let folder = URL(fileURLWithPath: NSTemporaryDirectory())
.appendingPathComponent(Self.kernelFolderPrefix + UUID().uuidString, isDirectory: true)
guard (try? FileManager.default.createDirectory(at: folder, withIntermediateDirectories: false,
attributes: [.posixPermissions: 0o700])) != nil
else { throw VMBackendError.failed("Couldn't make a folder for the Linux kernel download.") }
defer { try? FileManager.default.removeItem(at: folder) }
let archive = folder.appendingPathComponent(kernel.url.lastPathComponent)
output("Downloading the Linux kernel…")
let throttle = ProgressThrottle()
do {
try await FileDownload.fetch(kernel.url, to: archive) { written, expected in
// One line a percent, so the log keeps what came before the download.
let step = expected.map { Int(written * 100 / max($0, 1)) } ?? Int(written / 10_000_000)
if throttle.advance(to: step) { output(Self.kernelProgress(written, of: expected)) }
}
} catch {
throw VMBackendError.failed("Couldn't download the Linux kernel. Check your connection and try again.")
}
output("Installing the Linux kernel…")
let result = try await step(["system", "kernel", "set", "--tar", archive.path, "--binary", kernel.binaryPath,
"--digest", kernel.digest, "--force"],
timeout: 10 * 60, output: output, named: "Installing the Linux kernel")
guard result.status == 0 else { throw VMBackendError.failed("Couldn't install the Linux kernel: \(result.lastLine)") }
}
struct RecommendedKernel: Equatable {
let url: URL
let binaryPath: String
let digest: String
}
/// From `system property list --format json`; nil when the runtime doesn't say.
static func recommendedKernel(in json: String) -> RecommendedKernel? {
struct Properties: Decodable {
struct Kernel: Decodable {
let url: String?
let binaryPath: String?
let digest: String?
}
let kernel: Kernel?
}
guard let kernel = (try? JSONDecoder().decode(Properties.self, from: Data(json.utf8)))?.kernel,
let url = kernel.url.flatMap(URL.init(string:)),
let binaryPath = kernel.binaryPath, !binaryPath.isEmpty,
let digest = kernel.digest, digest.hasPrefix("sha256:")
else { return nil }
return RecommendedKernel(url: url, binaryPath: binaryPath, digest: digest)
}
static func kernelProgress(_ written: Int64, of expected: Int64?) -> String {
func megabytes(_ bytes: Int64) -> Int { Int((Double(bytes) / 1_000_000).rounded()) }
guard let expected else { return "Downloading the Linux kernel… \(megabytes(written)) MB" }
return "Downloading the Linux kernel… \(megabytes(written)) of \(megabytes(expected)) MB"
}
// MARK: Quit path
public func destroyBlocking(ids: [String], deadline: Duration) {
@@ -309,3 +445,16 @@ public final class ContainerCLIBackend: VMBackend {
}
}
}
private final class ProgressThrottle: Sendable {
private let last = Mutex(-1)
/// True the first time each step is reached.
func advance(to step: Int) -> Bool {
last.withLock { last in
guard step > last else { return false }
last = step
return true
}
}
}
@@ -557,7 +557,7 @@ public final class SessionController {
}
}
/// No VM exists yet, so there is nothing to destroy. Starting the service needs no password, so it just happens.
/// No VM exists yet, so there is nothing to destroy. Starting the service or fetching its kernel needs no password, so it just happens.
private func needsSetup(_ issue: SetupIssue, for session: Session) {
session.retired = true
liveIDs.remove(session.id)
@@ -752,11 +752,12 @@ public final class SessionController {
if mode == .link || pendingURL != nil { transition(to: card) } else { enterIdle() }
}
/// A check only starts the service: the kernel is a 700 MB download, so it waits for Set Up.
private static func fixes(_ issue: SetupIssue, in mode: RunMode) -> Bool {
switch (mode, issue) {
case (.window(continuing: true), .serviceStopped), (.window(continuing: true), .kernelMissing),
(.window(continuing: true), .imageMissing), (.window(continuing: true), .imageOutdated),
(.check, .serviceStopped), (.check, .kernelMissing):
(.check, .serviceStopped):
true
default:
false
@@ -767,7 +768,6 @@ public final class SessionController {
private static func sameFix(_ a: SetupIssue, _ b: SetupIssue) -> Bool {
func group(_ issue: SetupIssue) -> Int? {
switch issue {
case .serviceStopped, .kernelMissing: 0
case .imageMissing, .imageOutdated, .imageStale: 1
default: nil
}
@@ -925,6 +925,9 @@ public final class SessionController {
case StreamError.protocolViolation(let detail): "The VM sent a malformed message: \(detail)."
case StreamError.timedOut: "The VM didn't answer in time."
case StreamError.refused: "Couldn't connect to the VM."
case CLIRunner.Failure.timedOut: "The container runtime stopped responding. Try again."
case CLIRunner.Failure.notInstalled: "Apple's container runtime isn't installed."
case CLIRunner.Failure.launchFailed(let detail): "Couldn't run the container runtime: \(detail)"
default: String(describing: error)
}
}
@@ -0,0 +1,100 @@
import Foundation
/// A data task streamed into a file, so a partial download lives only in its own folder.
final class FileDownload: NSObject, URLSessionDataDelegate, @unchecked Sendable {
// Touched only on the session's serial delegate queue.
private var continuation: CheckedContinuation<Void, any Error>?
/// A completion that arrived before anyone waited: a task cancelled before it started.
private var outcome: Result<Void, any Error>?
private var handle: FileHandle?
private var written: Int64 = 0
private var expected: Int64?
private var writeError: (any Error)?
private let destination: URL
private let progress: @Sendable (_ written: Int64, _ expected: Int64?) -> Void
private init(destination: URL, progress: @escaping @Sendable (Int64, Int64?) -> Void) {
self.destination = destination
self.progress = progress
}
/// `expected` is nil when the server doesn't say.
static func fetch(_ url: URL, to destination: URL,
progress: @escaping @Sendable (_ written: Int64, _ expected: Int64?) -> Void) async throws {
let delegate = FileDownload(destination: destination, progress: progress)
let queue = OperationQueue()
queue.maxConcurrentOperationCount = 1
let session = URLSession(configuration: .ephemeral, delegate: delegate, delegateQueue: queue)
defer { session.finishTasksAndInvalidate() }
// Created up front: cancelling before it exists would invalidate the session, and creating it then throws.
let task = session.dataTask(with: url)
try await withTaskCancellationHandler {
try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, any Error>) in
queue.addOperation {
if let outcome = delegate.outcome {
continuation.resume(with: outcome)
} else {
delegate.continuation = continuation
task.resume()
}
}
}
} onCancel: {
task.cancel()
}
}
func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive response: URLResponse,
completionHandler: @escaping @Sendable (URLSession.ResponseDisposition) -> Void) {
if let http = response as? HTTPURLResponse, !(200..<300).contains(http.statusCode) {
writeError = URLError(.badServerResponse)
return completionHandler(.cancel)
}
do {
guard FileManager.default.createFile(atPath: destination.path, contents: nil) else {
throw CocoaError(.fileWriteUnknown, userInfo: [NSFilePathErrorKey: destination.path])
}
handle = try FileHandle(forWritingTo: destination)
} catch {
writeError = error
return completionHandler(.cancel)
}
if response.expectedContentLength > 0 { expected = response.expectedContentLength }
completionHandler(.allow)
}
func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive data: Data) {
guard let handle, writeError == nil else { return }
do {
try handle.write(contentsOf: data)
written += Int64(data.count)
progress(written, expected)
} catch {
writeError = error
dataTask.cancel()
}
}
func urlSession(_ session: URLSession, task: URLSessionTask, didCompleteWithError error: (any Error)?) {
try? handle?.close()
handle = nil
// Ours comes first: cancelling after it adds a "cancelled" error.
let result: Result<Void, any Error> = if let failure = writeError ?? error { .failure(failure) } else { .success(()) }
if let waiting = continuation {
continuation = nil
waiting.resume(with: result)
} else {
outcome = result
}
}
}
extension FileDownload {
static func removeFolders(prefix: String) {
let temporary = URL(fileURLWithPath: NSTemporaryDirectory())
let names = (try? FileManager.default.contentsOfDirectory(atPath: temporary.path)) ?? []
for name in names where name.hasPrefix(prefix) {
try? FileManager.default.removeItem(at: temporary.appendingPathComponent(name))
}
}
}
@@ -58,7 +58,7 @@ public struct SystemRuntimeInstaller: RuntimeInstalling {
}
let package = DownloadedPackage(directory: directory, name: release.url.lastPathComponent)
do {
try await PackageDownload.fetch(release.url, to: package.file, progress: progress)
try await FileDownload.fetch(release.url, to: package.file) { written, _ in progress(written) }
} catch {
discard(package)
throw DownloadError.failed(error.localizedDescription)
@@ -76,11 +76,7 @@ public struct SystemRuntimeInstaller: RuntimeInstalling {
/// Folders left by quitting mid-download or a crash.
public static func removeLeftovers() {
let temporary = URL(fileURLWithPath: NSTemporaryDirectory())
let names = (try? FileManager.default.contentsOfDirectory(atPath: temporary.path)) ?? []
for name in names where name.hasPrefix("knotchy-runtime-") {
try? FileManager.default.removeItem(at: temporary.appendingPathComponent(name))
}
FileDownload.removeFolders(prefix: "knotchy-runtime-")
}
@MainActor
@@ -122,88 +118,3 @@ private final class RunningInstaller: InstallerSession {
var hasQuit: Bool { app.isTerminated }
}
/// A data task streamed into the package file, so the partial download lives only in its own folder.
private final class PackageDownload: NSObject, URLSessionDataDelegate, @unchecked Sendable {
// Touched only on the session's serial delegate queue.
private var continuation: CheckedContinuation<Void, any Error>?
/// A completion that arrived before anyone waited: a task cancelled before it started.
private var outcome: Result<Void, any Error>?
private var handle: FileHandle?
private var written: Int64 = 0
private var writeError: (any Error)?
private let destination: URL
private let progress: @Sendable (Int64) -> Void
private init(destination: URL, progress: @escaping @Sendable (Int64) -> Void) {
self.destination = destination
self.progress = progress
}
static func fetch(_ url: URL, to destination: URL, progress: @escaping @Sendable (Int64) -> Void) async throws {
let delegate = PackageDownload(destination: destination, progress: progress)
let queue = OperationQueue()
queue.maxConcurrentOperationCount = 1
let session = URLSession(configuration: .ephemeral, delegate: delegate, delegateQueue: queue)
defer { session.finishTasksAndInvalidate() }
// Created up front: cancelling before it exists would invalidate the session, and creating it then throws.
let task = session.dataTask(with: url)
try await withTaskCancellationHandler {
try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, any Error>) in
queue.addOperation {
if let outcome = delegate.outcome {
continuation.resume(with: outcome)
} else {
delegate.continuation = continuation
task.resume()
}
}
}
} onCancel: {
task.cancel()
}
}
func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive response: URLResponse,
completionHandler: @escaping @Sendable (URLSession.ResponseDisposition) -> Void) {
if let http = response as? HTTPURLResponse, !(200..<300).contains(http.statusCode) {
writeError = URLError(.badServerResponse)
return completionHandler(.cancel)
}
do {
guard FileManager.default.createFile(atPath: destination.path, contents: nil) else {
throw CocoaError(.fileWriteUnknown, userInfo: [NSFilePathErrorKey: destination.path])
}
handle = try FileHandle(forWritingTo: destination)
} catch {
writeError = error
return completionHandler(.cancel)
}
completionHandler(.allow)
}
func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive data: Data) {
guard let handle, writeError == nil else { return }
do {
try handle.write(contentsOf: data)
written += Int64(data.count)
progress(written)
} catch {
writeError = error
dataTask.cancel()
}
}
func urlSession(_ session: URLSession, task: URLSessionTask, didCompleteWithError error: (any Error)?) {
try? handle?.close()
handle = nil
// Ours comes first: cancelling after it adds a "cancelled" error.
let result: Result<Void, any Error> = if let failure = writeError ?? error { .failure(failure) } else { .success(()) }
if let waiting = continuation {
continuation = nil
waiting.resume(with: result)
} else {
outcome = result
}
}
}
+29 -8
View File
@@ -17,8 +17,10 @@ public final class SetupFlow {
case update
}
public static let requiredFreeBytes: Int64 = 3_000_000_000
/// The build peaks at about 9 GB: the builder alone takes 4 GB until it is deleted. About 5 GB stays in use.
public static let requiredFreeBytes: Int64 = 10_000_000_000
static let vmDetail = "About 3 minutes · downloads about 225 MB"
static let kernelDownloading = "Downloading the Linux kernel…"
public private(set) var mac: Status = .pending("Checking…")
public private(set) var unsupported: Unsupported?
@@ -51,10 +53,11 @@ public final class SetupFlow {
/// With the controller's live progress on top, so a setup the notch started shows here too.
public var runtime: Status {
if case .settingUp(let issue) = driver.state, issue == .serviceStopped || issue == .kernelMissing {
return .running("Starting the runtime…", fraction: nil)
switch driver.state {
case .settingUp(.serviceStopped): return .running("Starting the runtime…", fraction: nil)
case .settingUp(.kernelMissing): return .running(driver.setupLog ?? Self.kernelDownloading, fraction: nil)
default: return runtimeBase
}
return runtimeBase
}
public var vm: Status {
@@ -142,6 +145,9 @@ public final class SetupFlow {
switch await driver.checkSetup() {
case .ready?: vmBase = .done("Ready")
case .needs(let issue)? where Self.isImageIssue(issue): vmBase = .pending(Self.vmDetail)
case .needs(.kernelMissing)?:
runtimeBase = .pending(Self.kernelDetail(version))
vmBase = .pending(Self.vmDetail)
case .failed(let issue, let message)?: fail(issue, message)
case nil where Self.isBrowserOpen(driver.state): vmBase = .done("Ready") // A running VM has an image.
case .needs?, nil: break // Busy, or the runtime row's business: the live rows show it.
@@ -264,7 +270,7 @@ public final class SetupFlow {
continue
}
switch checked {
case .needs(let issue) where Self.isImageIssue(issue):
case .needs(let issue) where Self.isImageIssue(issue) || issue == .kernelMissing:
guard let result = await driver.runSetup(issue, continuing: true) else { continue }
return apply(result)
case .needs:
@@ -279,14 +285,25 @@ public final class SetupFlow {
private func apply(_ outcome: SetupRunOutcome) {
switch outcome {
case .ready:
kernelInstalled()
vmBase = .done("Ready")
case .needs(let issue):
if Self.isImageIssue(issue) { vmBase = .pending(Self.vmDetail) }
if Self.isImageIssue(issue) {
kernelInstalled()
vmBase = .pending(Self.vmDetail)
}
case .failed(let issue, let message):
if Self.isImageIssue(issue) { kernelInstalled() }
fail(issue, message)
}
}
/// The run got past the kernel, so a row still waiting for it is done.
private func kernelInstalled() {
guard case .pending = runtimeBase, runtimeAction == nil, case .current(let version)? = runtimeStatus else { return }
runtimeBase = .done(Self.installedText(version))
}
private func fail(_ issue: SetupIssue, _ message: String) {
if Self.isImageIssue(issue) {
vmBase = .failed(message, details: driver.setupOutput)
@@ -309,7 +326,7 @@ public final class SetupFlow {
guard let facts else { return }
let free = facts.bytesFree.map { "\(Self.gigabytes($0)) GB free" }
if needsSpace, let bytes = facts.bytesFree, bytes < Self.requiredFreeBytes {
mac = .failed("Setting up needs about 3 GB free. \(Self.gigabytes(bytes)) GB is free.", details: [])
mac = .failed("Setting up needs about 10 GB free. \(Self.gigabytes(bytes)) GB is free.", details: [])
} else {
mac = .done([facts.osVersion, free].compactMap { $0 }.joined(separator: " · "))
}
@@ -325,13 +342,17 @@ public final class SetupFlow {
// MARK: - Text
static func installDetail(_ release: ContainerRuntime.Release) -> String {
"Apple's container \(release.version) · \(megabytes(release.size)) MB · installs with Apple's Installer"
"Apple's container \(release.version) · \(megabytes(release.size)) MB, then a 700 MB Linux kernel · installs with Apple's Installer"
}
static func installedText(_ version: String?) -> String {
version.map { "container \($0) installed" } ?? "container installed"
}
static func kernelDetail(_ version: String?) -> String {
"\(installedText(version)) · still needs its Linux kernel (700 MB)"
}
static func downloadText(_ bytes: Int64, of total: Int64) -> String {
"Downloading… \(megabytes(bytes)) of \(megabytes(total)) MB"
}